Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend create_tcp_connection utility #568

Merged

Conversation

Creatone
Copy link
Contributor

It would be a great thing to set context options and ciphers to provide better security.

@Creatone Creatone force-pushed the extend-tcp-connection-util branch from 544be4c to cc28e21 Compare July 31, 2019 08:55
@StephenSorriaux
Copy link
Member

Hi,

Thanks for your PR. I agree this would be a good feature. However, I noticed you only changed one method, so, for instance, the client interface will not have a way to set those parameters. Am I missing something here?

@Creatone
Copy link
Contributor Author

Creatone commented Aug 6, 2019

Client can set this parameters in his handler.
For example:

class MySequentialThreadingHandler(SequentialThreadingHandler):
    def create_connection(self, *args, **kwargs):
        return create_tcp_connection(socket, options=MY_OPTIONS, ciphers=MY_CIPHERS,
                                     *args, **kwargs)

Copy link
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@StephenSorriaux StephenSorriaux merged commit ab0cd00 into python-zk:master Aug 6, 2019
@StephenSorriaux
Copy link
Member

On master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants