Skip to content

Commit

Permalink
Stop testing on PyPy 3.9.
Browse files Browse the repository at this point in the history
PyPy v7.3.17 no longer provides PyPy 3.9.

Also the test suite was flaky under PyPy 3.9.
  • Loading branch information
aaugustin committed Nov 12, 2024
1 parent 1f19487 commit 7438b8e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,10 @@ jobs:
- "3.11"
- "3.12"
- "3.13"
- "pypy-3.9"
- "pypy-3.10"
is_main:
- ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
exclude:
- python: "pypy-3.9"
is_main: false
- python: "pypy-3.10"
is_main: false
steps:
Expand Down
5 changes: 0 additions & 5 deletions tests/sync/test_connection.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import contextlib
import logging
import platform
import socket
import sys
import threading
Expand Down Expand Up @@ -564,10 +563,6 @@ def test_close_idempotency(self):
self.connection.close()
self.assertNoFrameSent()

@unittest.skipIf(
platform.python_implementation() == "PyPy",
"this test fails randomly due to a bug in PyPy", # see #1314 for details
)
def test_close_idempotency_race_condition(self):
"""close waits if the connection is already closing."""

Expand Down

0 comments on commit 7438b8e

Please sign in to comment.