-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix integrityerror during azure auth #750
base: master
Are you sure you want to change the base?
fix integrityerror during azure auth #750
Conversation
Codecov Report
@@ Coverage Diff @@
## master #750 +/- ##
==========================================
- Coverage 77.49% 77.27% -0.22%
==========================================
Files 324 325 +1
Lines 9845 9875 +30
Branches 1173 1180 +7
==========================================
+ Hits 7629 7631 +2
- Misses 2065 2088 +23
- Partials 151 156 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
"""Use upn as unique id""" | ||
return response.get("upn") | ||
"""Use subject (sub) claim as unique id.""" | ||
return response.get("sub") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes uid
for existing installations what would be a breaking change. Why is upn
not present in your claim?
I fixed this in my forked codebase. https://github.com/ex8/social-core/tree/fix-bug - I have been using that for the time being. |
Bug: #749
There was someone else solving the exact thing in a different backend: #298