Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integrityerror during azure auth #750

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tiago-peres
Copy link

Bug: #749

There was someone else solving the exact thing in a different backend: #298

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #750 (0e8ddac) into master (3fc92c0) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head 0e8ddac differs from pull request most recent head 388c0ae. Consider uploading reports for the commit 388c0ae to get more accurate results

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
- Coverage   77.49%   77.27%   -0.22%     
==========================================
  Files         324      325       +1     
  Lines        9845     9875      +30     
  Branches     1173     1180       +7     
==========================================
+ Hits         7629     7631       +2     
- Misses       2065     2088      +23     
- Partials      151      156       +5     
Flag Coverage Δ
unittests 77.27% <100.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
social_core/backends/azuread.py 79.68% <100.00%> (ø)
social_core/backends/clef.py 91.66% <0.00%> (-8.34%) ⬇️
social_core/pipeline/user.py 82.60% <0.00%> (-2.47%) ⬇️
social_core/backends/google.py 69.04% <0.00%> (-1.69%) ⬇️
social_core/tests/backends/oauth.py 98.57% <0.00%> (-1.43%) ⬇️
social_core/backends/saml.py 80.31% <0.00%> (-1.29%) ⬇️
social_core/backends/openstackdev.py 0.00% <0.00%> (ø)
social_core/utils.py 86.41% <0.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

"""Use upn as unique id"""
return response.get("upn")
"""Use subject (sub) claim as unique id."""
return response.get("sub")
Copy link
Member

@nijel nijel Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes uid for existing installations what would be a breaking change. Why is ⁣upn not present in your claim?

@ex8
Copy link

ex8 commented Jun 4, 2024

I fixed this in my forked codebase.

https://github.com/ex8/social-core/tree/fix-bug - I have been using that for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants