Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify add command help #9230

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

kinuax
Copy link
Contributor

@kinuax kinuax commented Mar 24, 2024

When we add some dependency it is appended in pyproject.toml and it is installed in the corresponding virtual environment. I would suggest to incorporate the installation action into the related help so that poetry list and poetry add --help are harmonized.

Pull Request Check List

Resolves: none

  • Added tests for changed code.
  • Updated documentation for changed code.

@kinuax kinuax force-pushed the clarify-add-command-help branch from 7350efd to ef3a39e Compare March 24, 2024 18:01
@abn abn enabled auto-merge (squash) March 24, 2024 18:05
@abn abn merged commit 4c24022 into python-poetry:main Mar 24, 2024
22 checks passed
@kinuax kinuax deleted the clarify-add-command-help branch March 24, 2024 18:14
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
@radoering radoering added the backport/1.8 Backport a PR to 1.8 through an automated PR label Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.8 Backport a PR to 1.8 through an automated PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants