Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak messaging re incompatible python versions #8423

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Sep 8, 2023

A probably futile attempt to slow the steady drip of people reporting that they don't understand what poetry is telling them about python versions.

switching from "the current project's Python requirement" to "the current project's supported Python range" is intended:

  • to encourage readers to realise that poetry has to think not only about the current environment but about the whole range for which their project declares support
  • to de-emphasise "requirement", I can see why people read that and think "but my environment does satisfy that requirement"

@dimbleby dimbleby force-pushed the docs-tweak-python-range branch from e10c5d4 to f30b049 Compare September 8, 2023 20:38
@radoering radoering force-pushed the docs-tweak-python-range branch from f30b049 to be7a4ac Compare September 9, 2023 09:55
@radoering radoering added the impact/docs Contains or requires documentation changes label Sep 9, 2023
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Deploy preview for website ready!

✅ Preview
https://website-rlg1ibw0h-python-poetry.vercel.app

Built with commit cbc1db9.
This pull request is being automatically deployed with vercel-action

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more `python` requirement in pyproject.md that probably should be replaced.

docs/faq.md Show resolved Hide resolved
@dimbleby
Copy link
Contributor Author

dimbleby commented Sep 9, 2023

There is one more python requirement in pyproject.md that probably should be replaced.

I'd decided to leave that one alone on the grounds that it wasn't really relevant to the confusion that I'm trying to address.

In that place, I think it's more helpful to be consistent with the pyproject.toml terminology, perhaps "requirement" -> "dependency" would make sense

@dimbleby dimbleby force-pushed the docs-tweak-python-range branch from be7a4ac to 32eb942 Compare September 9, 2023 11:15
@radoering
Copy link
Member

I don't care much. Since you have thought about it, that's fine with me.

@radoering radoering force-pushed the docs-tweak-python-range branch from 32eb942 to cbc1db9 Compare September 9, 2023 12:20
@radoering radoering merged commit fc57323 into python-poetry:master Sep 9, 2023
29 checks passed
@dimbleby dimbleby deleted the docs-tweak-python-range branch September 9, 2023 18:28
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants