Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix virtualenv constraint (PEP 440 compliant) #6402

Merged

Conversation

radoering
Copy link
Member

#6376 made poetry uninstallable via pip 🙈 (Seems we are missing some kind of smoke test that builds poetry and tries to install it.)

This PR fixes this regression by making the constraint PEP 440 compliant.

@neersighted neersighted added impact/backport Requires backport to stable branch backport/1.2 area/deps Related to representing and locking dependencies labels Sep 4, 2022
@radoering radoering merged commit 18dbb92 into python-poetry:master Sep 5, 2022
@poetry-bot
Copy link

poetry-bot bot commented Sep 5, 2022

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport-6402-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18dbb92d97206ff1e1e9d4625f2b973e80428644
# Push it to GitHub
git push --set-upstream origin backport-6402-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport-6402-to-1.2.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
@radoering radoering deleted the fix-virtualenv-constraint-pep440 branch November 24, 2024 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/deps Related to representing and locking dependencies impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants