Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to --dev-only install option #5771

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

lafrenierejm
Copy link
Contributor

@lafrenierejm lafrenierejm commented Jun 4, 2022

According to @finswimmer in #4864 (comment):

The --dev-only option was never available in a release, but was already available in the master branch. Because it's a feature we will probably not backport this to the 1.1 branch.

Given that the option was only ever present when installing Poetry from master and was never available as part of a release, I think it's clearer to just remove all references to it rather than include a deprecation notice that would only be relevant to a tiny fraction of Poetry users.

Pull Request Check List

Resolves: #4864

  • Added tests for changed code.
  • Updated documentation for changed code.

According to
python-poetry#4864 (comment):
> The `--dev-only` option was never available in a release, but was already
> available in the master branch. Because it's a feature we will probably not
> backport this to the 1.1 branch.

Given that the option was only ever present when installing Poetry from master
and was never available as part of a release, I think it's clearer to just
remove all references to it rather than include a deprecation notice that would
only be relevant to a tiny fraction of Poetry users.
@neersighted neersighted merged commit 865aa94 into python-poetry:master Jun 5, 2022
@lafrenierejm lafrenierejm deleted the remove-dev-only branch June 5, 2022 14:38
@lafrenierejm
Copy link
Contributor Author

@neersighted Can you trigger a redeploy of the docs? It looks like the removed option is still present on the website.

@neersighted
Copy link
Member

The workflow will run tonight -- we haven't added a manual trigger, though you're welcome to PR a workflow_dispatch event onto our workflows if you really feel strongly about maintainers being able to deploy early 😄

https://github.com/python-poetry/website/blob/main/.github/workflows/deploy-production.yml#L5

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install only dev dependencies
2 participants