Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only consider package links for sdist and bdist_wheels #5767

Merged
merged 2 commits into from
Sep 7, 2022
Merged

fix: only consider package links for sdist and bdist_wheels #5767

merged 2 commits into from
Sep 7, 2022

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Jun 4, 2022 •
edited
Loading

Only follow and lock links for packages of type sdist or bdist_wheel in PyPi repository.

Closes: #3649
Closes: #4903

(This is a port of #3656.)

@finswimmer finswimmer mentioned this pull request Jun 4, 2022
Closed
2 tasks
@finswimmer finswimmer requested a review from a team June 4, 2022 08:23
neersighted
neersighted requested changes Jun 5, 2022
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to see at least one or two regression tests validating this behavior in both find_links_for_package and _get_release_info -- assuming that we can mock those without things getting too tangled.

@finswimmer
Copy link
Member Author

LGTM, but I'd like to see at least one or two regression tests validating this behavior in both find_links_for_package and _get_release_info -- assuming that we can mock those without things getting too tangled.

Done.

@finswimmer finswimmer requested a review from neersighted June 7, 2022 19:32
@neersighted neersighted added impact/backport Requires backport to stable branch backport/1.2 labels Sep 7, 2022
@neersighted neersighted added the impact/changelog Requires a changelog entry label Sep 7, 2022
@neersighted neersighted merged commit a38abcf into python-poetry:master Sep 7, 2022
poetry-bot bot pushed a commit that referenced this pull request Sep 7, 2022
@finswimmer @github-actions
fix: only consider package links for sdist and bdist_wheels (#5767)
9f76dd1 
Only follow and lock links for packages of type `sdist` or `bdist_wheel`
in PyPi repository.

Closes: #3649
Closes: #4903

(This is a port of #3656.)

(cherry picked from commit a38abcf)
@poetry-bot poetry-bot bot mentioned this pull request Sep 7, 2022
Merged
neersighted pushed a commit that referenced this pull request Sep 7, 2022
@finswimmer @neersighted
fix: only consider package links for sdist and bdist_wheels (#5767)
0f385cb 
Only follow and lock links for packages of type `sdist` or `bdist_wheel`
in PyPi repository.

Closes: #3649
Closes: #4903

(This is a port of #3656.)

(cherry picked from commit a38abcf)
@radoering radoering mentioned this pull request Sep 13, 2022
Merged
@finswimmer finswimmer mentioned this pull request Oct 21, 2022
Closed
@dimbleby dimbleby mentioned this pull request Dec 7, 2022
Closed
4 tasks
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted neersighted approved these changes

Assignees
No one assigned
Labels
impact/backport Requires backport to stable branch impact/changelog Requires a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not install 'stylus': EnvCommandError poetry unable to install hbmqtt
2 participants
@finswimmer @neersighted