Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect hash algorithm when verifying downloaded archives. #4486

Closed
wants to merge 2 commits into from
Closed

respect hash algorithm when verifying downloaded archives. #4486

wants to merge 2 commits into from

Conversation

kaos
Copy link

@kaos kaos commented Sep 8, 2021

Signed-off-by: Andreas Stenius [email protected]

Resolves: #4085

  • Added tests for changed code.

Depends on python-poetry/poetry-core#196, so marked as draft until there is a new poetry-core version we can use here.

@neersighted neersighted marked this pull request as ready for review November 12, 2021 13:39
neersighted
neersighted requested changes Nov 12, 2021
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kaos -- this looks good in light of the past state of the master branch, but things have changed... A fusion of your (and the other PR) to poetry-core has landed, and another PR has factored out the hash checking code. Could you rebase your changes/new tests on top of those? I'd like to get this landed to fix Artifactory support.

@neersighted neersighted self-assigned this Nov 12, 2021
@neersighted
Copy link
Member

Should close #4578 as well.

@neersighted neersighted mentioned this pull request Nov 12, 2021
Closed
2 tasks
@kaos
Copy link
Author

kaos commented Nov 12, 2021

It would be more effective if someone who knows the code does this. I'm not up to speed with what changes have been made, nor what changes I made any more.
It is a small diff, so shouldn't be that hard to re-implement either.

@neersighted
Copy link
Member

Sounds good. I'll likely leave this open until I (or someone else) create a new PR on top of the recent refactors.

@neersighted neersighted linked an issue Nov 12, 2021 that may be closed by this pull request
Enable multiple file hashing methods for backwards and forwards compatibility #4578
Closed
2 tasks
@neersighted neersighted mentioned this pull request Nov 12, 2021
Closed
neersighted added a commit that referenced this pull request Nov 12, 2021
@neersighted @kaos
feat: Support algorithms other than sha256 when validating hashes
a38ec72 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.

Co-authored-by: Andreas Stenius <[email protected]>
@neersighted
Copy link
Member

Successor PR (#4740) created!

@kaos kaos deleted the executor_verify_downloaded_archives branch November 12, 2021 17:15
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
This allows for much-improved compatibility when interfacing with legacy
16c445c 
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
feat: Check all hash types when validating archives
ad027bb 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
feat: Check all hash types when validating archives
d4498a1 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
feat: Check all hash types when validating archives
9b8715c 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
feat: Check all hash types when validating archives
6b08351 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
feat: Check all hash types when validating archives
1623d99 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 15, 2021
@neersighted
feat: Check all hash types when validating archives
9d5dcf1 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 16, 2021
@neersighted
feat: Check all hash types when validating archives
50b4b43 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 19, 2021
@neersighted
feat: Check all hash types when validating archives
d342448 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted neersighted requested changes

Assignees

@neersighted neersighted

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kaos @neersighted