Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort extras constraints of dependencies in lockfile #2308

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Sort extras constraints of dependencies in lockfile #2308

merged 1 commit into from
Apr 14, 2020

Conversation

osantana
Copy link
Contributor

@osantana osantana commented Apr 14, 2020

The extras constraints ordering is not guaranteed on metadata and it causes changes in poetry.lock file during the update process even when the dependency did not change.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

The extras constraints ordering is not guaranteed
on metadata and it causes changes on poetry.lock
file during update process even when the dependency
did not changed.

This patch orders this constraint for lock file
generation changing this behaviour.
@finswimmer finswimmer requested a review from a team April 14, 2020 16:27
@abn abn merged commit f45ec45 into python-poetry:develop Apr 14, 2020
@osantana
Copy link
Contributor Author

Thanks!

@br3ndonland br3ndonland mentioned this pull request Apr 24, 2021
2 tasks
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants