Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0a2: installer.remove_untracked -> adds installer.requires_synchronization(True) #1

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

jtzero
Copy link
Contributor

@jtzero jtzero commented Aug 3, 2021

the function has been moved to Solver

fixes error


  AttributeError

  'Installer' object has no attribute 'remove_untracked'

  at ~/.asdf/installs/python/3.8.5/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/poetry_bundle_plugin/bundlers/venv_bundler.py:133 in bundle
      129│             poetry.locker,
      130│             poetry.pool,
      131│             poetry.config,
      132│         )
    → 133│         installer.remove_untracked()
      134│         installer.use_executor(poetry.config.get("experimental.new-installer", False))
      135│
      136│         return_code = installer.run()
      137│         if return_code:

@jtzero jtzero changed the title removes reference installer.remove_untracked 1.2.0a2: installer.remove_untracked -> adds installer.requires_synchronization(True) Aug 4, 2021
@MaciejKucia
Copy link

@sdispater Can this fix be merged? Thanks.
As an alternative what would be the compatible poetry version?

@talhajunaidd
Copy link

I'm also facing the same issue, can we please merge the fix?

@jwillikers
Copy link

Same issue.

@talhajunaidd
Copy link

any update?

@mgb-ingenuity
Copy link

What's the status on this?

@RockyMM
Copy link

RockyMM commented Jan 20, 2022

Just to add -> same issue. Any chance for a merge?

Maybe @sdispater could lend a hand here 🙏

@mgb-ingenuity

This comment has been minimized.

src/poetry_bundle_plugin/bundlers/venv_bundler.py Outdated Show resolved Hide resolved
`installer.remove_untracked` -> adds installer.requires_synchronization(True)
Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jtzero, and sorry for the long delay. I'll try to get this published asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants