Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editable installs with extension modules #633

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

robbotorigami
Copy link
Contributor

Resolves: python-poetry/poetry#8377

Credit to @matthewwardrop for the fix (#335). I've rebased onto the current main branch and added unit tests for the modified functionality. I've also tested against the projects I was having issues with and confirmed that this resolves the issues I was having.

@robbotorigami robbotorigami force-pushed the fix_editable_installs branch 2 times, most recently from 3061c8a to b406de0 Compare August 30, 2023 20:09
@robbotorigami robbotorigami force-pushed the fix_editable_installs branch from b406de0 to 6b861c6 Compare August 30, 2023 20:13
@robbotorigami robbotorigami force-pushed the fix_editable_installs branch from 6b861c6 to d1d0865 Compare August 31, 2023 18:44
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects with extension modules no longer installed in editable mode
4 participants