-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Py3.8 support to add potential Py3.13 support #863
Conversation
Officially EOL by Python project Run `poetry update` Drop "backports.zoneinfo", importlib-resources Bump time-machine, pytest-codspeed to last version which support Py3.13 https://github.com/adamchainz/time-machine/blob/main/CHANGELOG.rst https://github.com/CodSpeedHQ/pytest-codspeed/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue for now, let's see what CI says
CodSpeed Performance ReportMerging #863 will degrade performances by 91.71%Comparing 🎉 Hooray!
|
Benchmark | master |
M5oul:master |
Change | |
---|---|---|---|---|
❌ | test_parse_iso8601 |
1.2 ms | 14.3 ms | -91.71% |
Directly import `zoneinfo` and `importlib.resources` in the files where used
I am no expert on Rust/PyO3, but are the changes to the code needed? There is a huge performance regression. It's unmergable in that state. |
I cherry-picked last commit from https://github.com/dlt-hub/pendulum/, otherwise, we get
|
As said in codspeed message:
I gave it a try to compare on Py3.12, with only bumping
I don’t have this table with previous versions, not sure which value should be taken. |
I will try to find some time to test the changes myself. I just want to be extra careful and double-check everything. |
@M5oul How can I solve problem about rust impl? |
Ok, I have tested the changes locally and it seems to be alright, gonna merge it and see how it behaves with some PRs I plan on merging soon-ish. |
at least from the dependencies point of view.
Bumping dependencies, which dropped Py3.8 supports, also adds Py3.13 support.
(#844)