Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse invalid interval string #860

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rchindris
Copy link

@rchindris rchindris commented Nov 15, 2024

The function _parse_iso8601_interval raises IndexError when either the first or the last part of the interval is not specified. This fix checks if the interval parts are empty strings and raises ParserError if so.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@rchindris rchindris changed the title fix parse invalid interval string Fix parse invalid interval string Nov 18, 2024
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #860 will not alter performance

Comparing rchindris:master (c44ffb0) with master (b84b976)

Summary

✅ 1 untouched benchmarks

@Secrus
Copy link
Collaborator

Secrus commented Nov 21, 2024

Please rebase your changes with master to fix the failing pipeline

@rchindris
Copy link
Author

@Secrus 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants