Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Optimize usage of re.* methods #741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor: Optimize usage of re.* methods #741

wants to merge 1 commit into from

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Aug 19, 2023

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 19, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #741 will degrade performances by 19.38%

Comparing eumiro:re-fullmatch (14459f8) with master (d1a874d)

Summary

❌ 1 regressions
✅ 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master eumiro:re-fullmatch Change
❌ test_format 2.3 ms 2.8 ms -19.38%

@eumiro eumiro force-pushed the re-fullmatch branch 4 times, most recently from e32fded to e45b0db Compare August 19, 2023 19:45
@eumiro eumiro changed the title Use re.fullmatch to match whole strings Refactor: Optimize usage of re.* methods Aug 19, 2023
@eumiro eumiro marked this pull request as ready for review August 19, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eumiro