Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: Fix #595 #693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixup: Fix #595 #693

wants to merge 1 commit into from

Conversation

cosmix
Copy link

@cosmix cosmix commented Feb 28, 2023

This PR fixes #595, by re-exporting parse().

parse() should be re-exported so that the user can just call pendulum.parse() as documented, given that the module is marked with py.typed.

No tests have been modified or added for this bugfix.

@cosmix
Copy link
Author

cosmix commented Mar 1, 2023

Note that the failing CI test has to do with the fact that the flake8 module that you're using seems to not like the import aliasing that needs to be used to fix the issue addressed by this PR and that exports the parse symbol in __init__.py.

For reference, I'm using the type checker rules listed on the pyright README here, but, to my understanding these are rules common to more type checkers for Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pendulum.parse is not marked as exported (pyright type checker in VSCode)
2 participants