Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from_format using local timezone even when timezone is provided. #616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ayoung19
Copy link

@ayoung19 ayoung19 commented Apr 16, 2022

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Fixes #613

@ayoung19
Copy link
Author

NOTICE: Just a draft, need to work out the expected behavior with @sdispater as this new change defaults timezone to UTC when no timezone is provided (unlike locally before).

Copy link

@jamwine jamwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timezone within the now() will create a DateTime instance in accordance with the proper timezone.

@ayoung19
Copy link
Author

this is potentially breaking, but it is useful for how i'm using it at my company. do u think this is the correct behavior? it shouldnt be relying on the local timezone of the machine right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

breaking: from_format errors out when there is no local timezone configuration but timezone is passed in
2 participants