Minor updates in support of #569 #597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried adding workflow_dispatch, to enable manually triggering tests, but for reasons that remain unclear to me, that had no effect...
AFAICT, poetry 1.1.x will *not* work with the other updates on this branch. Using an upstream, tagged version, even if it's not an official release, seems somewhat less brittle.
patrickmckenna
changed the title
patrickmckenna
force-pushed
the
patrickmckenna/modernize-codebase
branch
from
673b9db to
aba8764
Compare
patrickmckenna
force-pushed
the
patrickmckenna/modernize-codebase
branch
from
aba8764 to
f5c40de
Compare
|
FWIW, the tests are passing. |
This reverts commit c44bceb.
They map 1-1, but the previous implementation turned ZoneInfo objs into FixedTimezone objs, which they generally aren't.
sdispater
force-pushed
the
modernize-codebase
branch
2 times, most recently
from
d501c47 to
607bab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sdispater given your obligations with Poetry, I thought it might help to open a fresh PR against #569, with the hope of nudging those massive, and eagerly anticipated(!), updates closer to release 😄. Hopefully this helps, but if not, please feel free to close/ignore/request further changes as you see fit.
Given the wide scope of that PR, the best way to help seemed to be taking the checklist in #569 (comment) at face value, i.e. assume the needed tests are written, and look into what docs updates are still needed. But before starting on that, it seemed like a few other minor updates were necessary:
master1.1, and I'm guessing that's a known issue—hence all the build scripts previously pointing to a newer, unreleased ref.READMEand build/release scripts to reference the right Python versions, based on 0c5b78e and 1102725.c44bceb was a temporary hack; I'll revert it.
Please LMK if this is on the right track. As far as substantive doc edits go, do you have a clear idea of what the minimum viable updates are? I'd guess that support for
zoneinfoTZs is among the most important changes to explain, but what other topics would you include?Hope this helps!
/cc @NickFabry @anvit25 (per #590 (comment))