is_birthday should be is_anniversary
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redlickigrzegorz
force-pushed
the
feature/272-is_birthday_should_be_is_anniversary
branch
from
7c76ddc to
a4033b7
Compare
jamesmyatt
reviewed
Oct 30, 2018
jamesmyatt
reviewed
Oct 30, 2018
jamesmyatt
reviewed
Nov 2, 2018
jamesmyatt
reviewed
Nov 2, 2018
|
@sdispater What do you think about my solution? Is it a good idea to think about the merge to resolve the problem? |
|
Good enough for me, but I'm not a contributor |
sdispater
approved these changes
Mar 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a pull request for implementing an alias for
is_birthday()method -> #272