-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to ignore POT-Creation-Date for updates #999
Add flag to ignore POT-Creation-Date for updates #999
Conversation
Ping @akx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! As mentioned inside, I think it could be more intuitive for the kwarg to be positive (and default to True).
My pleasure, thanks for taking a look! Just updated per your suggestion. |
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 90.90% 90.91%
=======================================
Files 25 25
Lines 4356 4358 +2
=======================================
+ Hits 3960 3962 +2
Misses 396 396
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the delay!
Adding a flag to ignore changes to POT-Creation-Date when performing updates or checks.
I use a CI check that ensures my .po files are updated before merging, but there is always a diff on POT-Creation-Date.
Related to #725 - but solving (my) problem via update instead of extract.