Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type annotation improvements:
Locale.parse
to always return aLocale
(this fixes type issues in multiple places where the return type is assumed to not be None)type: ignore
in certain places in core.py and numbers.pyNote: Changing
Locale.parse
to always return aLocale
simplifies the logic, but it also can potentially be a breaking change if people are relying on passingNone
not raising an exception. It is a bit of a stretch though, since passingNone
has no functional effect in the use of the lib.These changes have been separated from #961