-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement zoneinfo support and make pytz optional #940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! ❤️
Some change requests, a big one being that pytz
should IMO be supported alongside zoneinfo
and preferred where available for backward compatibility reasons.
I'm all ears if there's something I'm missing and that'd be a terrible idea. :D
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
==========================================
- Coverage 91.78% 90.53% -1.26%
==========================================
Files 23 24 +1
Lines 4348 4395 +47
==========================================
- Hits 3991 3979 -12
- Misses 357 416 +59
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! 😄
Fixes #716