Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isolated builds #499

Merged
merged 3 commits into from
Feb 9, 2019
Merged

Use isolated builds #499

merged 3 commits into from
Feb 9, 2019

Conversation

hynek
Copy link
Member

@hynek hynek commented Feb 9, 2019

OK it would be nice to use properly isolated builds but it seems like mypy is breaking with it.

Maybe someone can help with that?

@pganssle
Copy link
Member

pganssle commented Feb 9, 2019

I can't reproduce this failure locally on Arch Linux - same versions of Python and pip. Try restarting the build?

@hynek
Copy link
Member Author

hynek commented Feb 9, 2019

It works for me locally too and I tried multiple times. I’ve even reverted it on master after multiple attempts. :-/

@pganssle
Copy link
Member

pganssle commented Feb 9, 2019

On Twitter, @gaborbernat suggested this could be due to pypa/setuptools#1506. Does seem like the same general problem, but I'm not sure why you'd be picking up an old version of setuptools in the isolated build environment, and I still can't reproduce the problem even if I explicitly pin setuptools to an old version in the build-system.requires, which is extra puzzling.

pyproject.toml Outdated Show resolved Hide resolved
@bskinn
Copy link

bskinn commented Feb 9, 2019

I've found Travis's Python images sometimes have moderately outdated package versions bundled in.

Maybe mypy is out of date...what happens if you add a pip install -U --force-reinstall mypy to your install: section of .travis.yml?

@hynek hynek merged commit 2f63f2c into master Feb 9, 2019
@hynek hynek deleted the isolated-builds branch February 9, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants