Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 2 statement #498

Merged
merged 2 commits into from
Feb 10, 2019
Merged

Add Python 2 statement #498

merged 2 commits into from
Feb 10, 2019

Conversation

hynek
Copy link
Member

@hynek hynek commented Feb 9, 2019

Partly as another preparation for import attrs, I think it's good to spell out our Python 2 policy explicitly.

Feedback welcome!

@hynek hynek added this to the import attrs milestone Feb 9, 2019
@itamarst
Copy link

itamarst commented Feb 9, 2019

I have far fewer users, so different situation... but:

  1. You can release packages with version limiters, so like "version X runs on Python 2 and 3" and "version X+1 only runs on Python 3".
    Which means Python 2 users will continue to get version X even as you do X+1, X+2, X+3, etc..
  2. You can then do point releases for Python 2 if there are critical bug fixes, so like X.1, X.2.

Which means you can just drop Python 2 from the main development branch.

For Eliot I'm asking for money beyond a certain point, though that's somewhat orthogonal (https://eliot.readthedocs.io/en/stable/python2.html).

@hynek
Copy link
Member Author

hynek commented Feb 9, 2019

Which means you can just drop Python 2 from the main development branch.

Since we do CalVer, I think a separate package would make more sense.

For Eliot I'm asking for money beyond a certain point, though that's somewhat orthogonal

I might try that but my experience so far is that people don't like to give me money.

@wsanchez
Copy link

wsanchez commented Feb 9, 2019

I think the policy as written is sound. Let's worry about how to handle dropping Py2 when we get to the point that it's necessary. Options will depend on reasons for dropping.

@hynek hynek merged commit 7b37354 into master Feb 10, 2019
@hynek hynek deleted the py2-statement branch February 10, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants