Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about subclassing behavior #485

Merged
merged 3 commits into from
Feb 5, 2019
Merged

Add warning about subclassing behavior #485

merged 3 commits into from
Feb 5, 2019

Conversation

hynek
Copy link
Member

@hynek hynek commented Jan 20, 2019

Fixes #483

wsanchez
wsanchez approved these changes Feb 4, 2019
View reviewed changes
Copy link

@wsanchez wsanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. LGTM

@hynek hynek merged commit 87b2bb2 into master Feb 5, 2019
@hynek hynek deleted the cmp-false-subclassing branch February 5, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsanchez wsanchez wsanchez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hynek @wsanchez