Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python_requires in setup.py #454

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Add python_requires in setup.py #454

merged 1 commit into from
Oct 25, 2018

Conversation

williamjamir
Copy link
Contributor

This PR adds python_requires into setup.py to prevent pip from installing attrs in unsupported python versions.

I know that currently attrs supports a wide range of python versions but I think that it's always good to have some sanity check =)

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

  • Added tests for changed code.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

This PR adds `python_requires` into `setup.py` to prevent `pip` from installing `attrs` in unsupported python versions.

I know that currently `attrs` supports a wide range of python versions but I think that it's always good to have some sanity check =)
@hynek
Copy link
Member

hynek commented Oct 25, 2018

Sure, why not, thanks!

@hynek hynek merged commit 1a095d1 into python-attrs:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants