ENH: query attributes through private API to speed up validate.

[cournape]

Proposal fix for #28

[codecov-io]

Current coverage is 100.00%

Merging #29 into master will not affect coverage as of d1e18f5

@@            master     #29   diff @@
======================================
  Files            6       6       
  Stmts          310     310       
  Branches        71      71       
  Methods          0       0       
======================================
  Hit            310     310       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of d1e18f5

Powered by Codecov. Updated on successful CI builds.

[hynek]

Thanks!

So since the tests didn’t use to cover the error before (it came thru fields), the coverage sank.

But since the ValueError wasn’t documented before, but OTOH the docs explicitly ask for a decorated instance, I’m tending to not handle that special case at all.

[hynek]

you may want to use the delay I explained in the other ticket to add yourself to AUTHORS.rst and add the change to the changelog. Thanks!

[cournape]

I did, though it seems a bit of a steal given the trivial contribution :)

[hynek]

I have a simple “every change is sacred” policy. :) Also not the code alone counts but also the way there. A good bug report is +Inf times better than a half-assed patch.

That said, you forgot the changelog entry. :D (docs/changelog.rst)

[cournape]

here we go. Hope you had a good time in Tokyo !

[hynek]

It was…intense. :)

Thanks!

[cournape]

@hynek is there something I can help w/ to make 15.2.0 happen ?

[hynek]

I’m doing some repo janitoring right now and will release afterwards.