adding matches_re validator

[kurtbrose]

still needs more work just getting the ball rolling

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

• [*] Added tests for changed code.
• New features have been added to our Hypothesis testing strategy.
• Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
  • ...and used in the stub test file tests/typing_example.py.
• Updated documentation for changed code.
  • New functions/classes have to be added to docs/api.rst by hand.
  • Changes to the signature of @attr.s() have to be added by hand too.
  • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
• Documentation in .rst files is written using semantic newlines.
• Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

[hynek]

I know you said you're not done yet but here's some feedback so you can avoid detours when you'll find the time.

Also a changelog entry please. :)

[kurtbrose]

thanks for the comments, will address soon

sorry for the slowness, I've been a bit hung up on getting the local dev environment set up, I keep running into this:

> py.exe -m pip install -e .
Obtaining file:///C:/Users/Kurt/workspace/attrs
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  Complete output from command C:\Users\Kurt\AppData\Local\Programs\Python\Python37-32\python.exe C:\Users\Kurt\AppData\Local\Programs\Python\Python37-32\lib\site-packages\pip\_vendor\pep517\_in_process.py get_requires_for_build_wheel C:\Users\Kurt\AppData\Local\Temp\tmp2j45vhxz:
  Traceback (most recent call last):
    File "C:\Users\Kurt\AppData\Local\Programs\Python\Python37-32\lib\site-packages\pip\_vendor\pep517\_in_process.py", line 207, in <module>
      main()
    File "C:\Users\Kurt\AppData\Local\Programs\Python\Python37-32\lib\site-packages\pip\_vendor\pep517\_in_process.py", line 197, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "C:\Users\Kurt\AppData\Local\Programs\Python\Python37-32\lib\site-packages\pip\_vendor\pep517\_in_process.py", line 54, in get_requires_for_build_wheel
      return hook(config_settings)
    File "C:\Users\Kurt\AppData\Local\Temp\pip-build-env-m4ck65jz\overlay\Lib\site-packages\setuptools\build_meta.py", line 145, in get_requires_for_build_wheel
      return self._get_build_requires(config_settings, requirements=['wheel'])
    File "C:\Users\Kurt\AppData\Local\Temp\pip-build-env-m4ck65jz\overlay\Lib\site-packages\setuptools\build_meta.py", line 126, in _get_build_requires
      self.run_setup()
    File "C:\Users\Kurt\AppData\Local\Temp\pip-build-env-m4ck65jz\overlay\Lib\site-packages\setuptools\build_meta.py", line 141, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 99, in <module>
      + read("AUTHORS.rst")
  AttributeError: 'NoneType' object has no attribute 'group'

[hynek]

I wasn’t aware of that problem until recently. Could you help my understand how it happens in #561?

[hynek]

I believe pip install -dev on windows should work now?

[kurtbrose]

yes! worked like a charm after update, thanks!

[kurtbrose]

just an FYI, pre-commit still fails with an SSL failure trying to fetch black from github

Errors:
fatal: unable to access 'https://github.com/ambv/black/': error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

I've checked the code is flake8 clean, hopefully I'm not missing anything else format wise

[hynek]

just an FYI, pre-commit still fails with an SSL failure trying to fetch black from github

Errors:
fatal: unable to access 'https://github.com/ambv/black/': error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

Hm, that must be some local problem. Under what Python version is your pre-commit running? It must be something ancient, if the ssl is too old to connect to GitHub?! Anthony is AFAIK using Windows too, so that shouldn't be the issue. The tox env uses explicitly 3.7 tho?

(I've took this opportunity to fix black's URL tho)

I've checked the code is flake8 clean, hopefully I'm not missing anything else format wise

You did: https://attrs.visualstudio.com/attrs/_build/results?buildId=231&view=logs&jobId=810e27dd-b084-5a0b-5c49-7fe688ece5ee&taskId=2dbb6c1a-2c14-506e-d517-3d9e1024c6b7&lineStart=39&lineEnd=40&colStart=1&colEnd=1 😇

[hynek]

Hey a release is imminent; do you think you can bang it into shape on short notice or do you want to push this to the next release?

[kurtbrose]

let me give it one more push this weekend and see if I can resolve everything -- sorry for being so flakey!

[kurtbrose]

alright I think this is ready to go now ... only thing is I'm not sure about hypothesis or the type testing area

not sure if those apply since this is more of a "leaf" than structural

[hynek]

Thanks!