Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install fails on Windows #561

Closed
spigo900 opened this issue Aug 2, 2019 · 2 comments
Closed

Install fails on Windows #561

spigo900 opened this issue Aug 2, 2019 · 2 comments
Labels

Comments

@spigo900
Copy link

spigo900 commented Aug 2, 2019

Because of the way read() reads its input file, the string it returns will have different contents depending on the line ending used in the file. This means that the install fails on Windows, because the CHANGELOG regex looks for '\n', or LF, but since line endings are CRLF on Windows, the regex won't match.

See the log:

> pip install .
...
  Complete output from command c:\users\crazy\appdata\local\programs\python\python37\python.exe c:\users\crazy\appdata\local\programs\python\python37\lib\site-packages\pip\_vendor\pep517\_in_process.py get_requires_for_build_wheel C:\Users\crazy\AppData\Local\Temp\tmpghg6p1e3:
  Traceback (most recent call last):
    File "c:\users\crazy\appdata\local\programs\python\python37\lib\site-packages\pip\_vendor\pep517\_in_process.py", line 207, in <module>
      main()
    File "c:\users\crazy\appdata\local\programs\python\python37\lib\site-packages\pip\_vendor\pep517\_in_process.py", line 197, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "c:\users\crazy\appdata\local\programs\python\python37\lib\site-packages\pip\_vendor\pep517\_in_process.py", line 54, in get_requires_for_build_wheel
      return hook(config_settings)
    File "C:\Users\crazy\AppData\Local\Temp\pip-build-env-6f560u2s\overlay\Lib\site-packages\setuptools\build_meta.py", line 145, in get_requires_for_build_wheel
      return self._get_build_requires(config_settings, requirements=['wheel'])
    File "C:\Users\crazy\AppData\Local\Temp\pip-build-env-6f560u2s\overlay\Lib\site-packages\setuptools\build_meta.py", line 126, in _get_build_requires
      self.run_setup()
    File "C:\Users\crazy\AppData\Local\Temp\pip-build-env-6f560u2s\overlay\Lib\site-packages\setuptools\build_meta.py", line 141, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 99, in <module>
      + read("AUTHORS.rst")
  AttributeError: 'NoneType' object has no attribute 'group'
@hynek
Copy link
Member

hynek commented Aug 4, 2019

Huh! Where are those CRLF coming from? Was that some automatisms from git?

@wsanchez wsanchez added the Bug label Aug 6, 2019
@hynek hynek mentioned this issue Aug 9, 2019
9 tasks
@hynek
Copy link
Member

hynek commented Aug 19, 2019

I believe this should work now?

@hynek hynek closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants