Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsafe_hash for PEP 681 #1003

Closed
hynek opened this issue Aug 11, 2022 · 1 comment · Fixed by #1065
Closed

Add unsafe_hash for PEP 681 #1003

hynek opened this issue Aug 11, 2022 · 1 comment · Fixed by #1065
Labels
Feature Typing Typing/stub/Mypy/PyRight related bugs.
Milestone
22.2.0

Comments

@hynek
Copy link
Member

hynek commented Aug 11, 2022

I've been asked to add unsafe_hash as an alias for hash at class level for PEP 618 (data class transforms).

I'm not enthusiastic about the lack of symmetry between class-level and field-level hash but this is not the hill I'm dying on.
@hynek hynek added this to the 22.2.0 milestone Aug 11, 2022
@hynek hynek added Feature Typing Typing/stub/Mypy/PyRight related bugs. labels Aug 11, 2022
@nicktimko
Copy link
Contributor

nicktimko commented Sep 30, 2022 •
edited
Loading

PEP-681 not 618 if anyone's looking (title right, prose transposed), and specs are in PEP-557

@hynek hynek mentioned this issue Oct 6, 2022
Closed
@hynek hynek mentioned this issue Nov 30, 2022
Merged
21 tasks
hynek added a commit that referenced this issue Dec 1, 2022
@hynek
Add unsafe_hash alias for class-wide hash
26c5931 
Fixes #1003
@hynek hynek mentioned this issue Dec 1, 2022
Merged
12 tasks
hynek added a commit that referenced this issue Dec 1, 2022
@hynek
Add unsafe_hash alias for class-wide hash
acf9dbd 
Fixes #1003
hynek added a commit that referenced this issue Dec 2, 2022
@hynek
Add unsafe_hash alias for class-wide hash (#1065)
0f6a9b4 
* Add unsafe_hash alias for class-wide hash

Fixes #1003

* Add news fragment

* Add type hints / type examples

* Complete attr.s's api string in api.rst

* Address feedback

* Clarify

* Shuffle around
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Typing Typing/stub/Mypy/PyRight related bugs.
Projects
None yet
Milestone
22.2.0
Development

Successfully merging a pull request may close this issue.

Add unsafe_hash alias for class-wide hash python-attrs/attrs
2 participants
@hynek @nicktimko