python_api: handle array-like args in approx() #8137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This treats objects that expose an ndarray via the __array__ interface the same as direct subclasses of ndarray. Fixes pytest-dev#8132.
nicoddemus
reviewed
Dec 13, 2020
nicoddemus
added
the
needs backport
|
Thanks very much @jvansanten! I appreciate you being so responsive and helpful on getting this change to address my Issue. |
nicoddemus
pushed a commit
to nicoddemus/pytest
that referenced
this pull request
Dec 15, 2020
|
Backport: #8147 |
nicoddemus
added a commit
that referenced
this pull request
Dec 15, 2020
[6.2.x] python_api: handle array-like args in approx() #8137
nicoddemus
added
backported
and removed
needs backport
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This treats objects that expose an ndarray via the
__array__interface thesame as direct subclasses of ndarray. Fixes #8132.