Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracebacks and output for xfail and xpass with -rxX option #11735

Closed
wants to merge 5 commits into from
Closed

Add tracebacks and output for xfail and xpass with -rxX option #11735

wants to merge 5 commits into from

Conversation

okken
Copy link
Contributor

@okken okken commented Dec 23, 2023

This is builds off of @sturmf #11574 which closes #11233

I tried to push changes to Fabian's branch and I think I totally mucked it up.
So I'm starting fresh.

Changs over Fabian's work:

  • add tests
  • change bottom summary line for xfail to include the assert line

I think that's it.

@okken okken changed the title building on 11574: summary changes + testing for xfail and xpass building on 11574: Add summary for xfails with -rxX option Dec 23, 2023
@okken okken changed the title building on 11574: Add summary for xfails with -rxX option WIP: building on 11574: Add summary for xfails with -rxX option Dec 23, 2023
@okken okken changed the title WIP: building on 11574: Add summary for xfails with -rxX option building on 11574: Add summary for xfails with -rxX option Dec 26, 2023
@okken okken requested a review from nicoddemus December 26, 2023 00:30
@okken
Copy link
Contributor Author

okken commented Dec 27, 2023

I backed out "adding assert failure" to xfail summary, as it broke [NOTRUN] behavior for xfail in test_skipping.py and I couldn't figure out how to get around that.

However, running with --tb=line (or really anything more than --tb=no) is a sufficient workaround

@okken okken changed the title building on 11574: Add summary for xfails with -rxX option Add tracebacks and output for xfail and xpass with -rxX option Dec 27, 2023
@okken
Copy link
Contributor Author

okken commented Jan 2, 2024

All of these changes have been merged to #11574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-rx and -rX should turn on output for xfail/xpass
1 participant