-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semver color output representation #73
Conversation
Hi! Thank you for your contribution. It really like it 👍 Could you share some screenshots of the colored rendering? I'm afraid the uppercase word looks a bit "rough" - may be we could add a dash or some sort of punctuation. What do you think? FYI I'm going on vacation for a week so I may take some time to answer 😉 |
@pyrech PR code and desc updated, feel free to comment/ give feedback on both outputs Yes I am too until eomonth, have a nice break :) |
714cee2
to
50f3768
Compare
50f3768
to
8013cc6
Compare
friendly ping @pyrech 👋 |
Thanks for the ping 😅. I'll review this PR right now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, I like the rendering 👍
I just left 2 minor comments
yes we can, I'll update the comparison operation appart from that, do you prefer the first or second display (PR desc, for my part I prefer the first) thx ! |
I also prefer the first 👍 |
6b642bc
to
c32c109
Compare
@pyrech here you are, PR code and desc updated accordingly :) |
Oops, I needed to approve the run of CI and it looks like the tests are broken (I think you just need to fix assertion with the added precisions) |
c32c109
to
48b165e
Compare
48b165e
to
baeec42
Compare
Indeed, while checking the test, I found that I had to deal with |
Awesome, lets' merge and release this one! Thanks @noniagriconomie for your contribution! |
Is there anything that can be done for other terminal themes? The white on yellow is not legible. Edit: I'm using Hyper terminal with Material theme |
Hello @mikemand This looks indeed not optimal. Maybe we should remove these colored background to fix these accessibility problems. Would you mind to give a try ? |
Hi @pyrech Sure! I'll get a PR opened ASAP. Should we keep the colors, and just use |
Hi
First thanks for this plugin :)
I would like to propose this kind of improvement on the output for kind of eye alerting:
Thank you!