Fix bad return code in bash activation if hashing is disabled #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If hashing is disabled in bash, the `hash` command will return a nonzero return code. Since it is the last command in the script that return code will also be the "return code" of the source command, so if anyone uses source activate.sh || die horribly having hashing disabled will ruin their day. Fix this by overriding the return code of `hash` if it's bad. Add tests to verify a good return code and try with and without hashing.
|
Ah, looks like I wedged in before #2721. Rebased, let's try again. |
|
[email protected] on macos timed out? 🤨 maybe it just had a bad day and needs a rerun? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If hashing is disabled in bash, the
hashcommand will return a nonzero return code. Since it is the last command in the script that return code will also be the "return code" of the source command, so if anyone usessource activate.sh || die horribly
having hashing disabled will ruin their day.
Fix this by overriding the return code of
hashif it's bad. Add tests to verify a good return code and try with and without hashing.Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder