Update activate_this.py documentation to use runpy instead of exec #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmoore
reviewed
May 8, 2024
tasks/make_zipapp.py
Outdated
| @@ -180,7 +180,7 @@ def get_dependencies(whl, version): | |||
| platforms = [] | |||
| platform_positions = WheelDownloader._marker_at(markers, "sys_platform") | |||
| deleted = 0 | |||
| for pos in platform_positions: # can only be ore meaningfully | |||
| for pos in platform_positions: # can only be more meaningfully | |||
There was a problem hiding this comment.
"more" doesn't make sense here. Was the typo meant to be "one"? I'm not sure if that makes any more sense, but at least it's a grammatically complete phrase...
There was a problem hiding this comment.
tbh - that whole comment didn't make sense to me either - but pre-commit wanted to change it. I'm happy to leave it out, since it's in a file I was not really interested in :)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runpy.run_path was added in python 2.7 and 3.2 - and every python that is not EOL supports it.
It is arguably nicer to read and the path is only given once in the command.
At least right now, runpy - unlike exec with S102 - is not flagged by bandit or bandit-derived (eg. ruff) checks.
(I guess because it loads from a file instead of a simple string...)
Because of the import, it is also not a one-liner anymore.
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder: This is a tiny change, so I'm not sure it warrants a news fragment