Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ update and simplify nushell activation #2572

Merged
merged 2 commits into from
May 17, 2023

Conversation

melMass
Copy link
Contributor

@melMass melMass commented May 17, 2023

  • Storing "Old" env variables is handled by overlays OOB
  • Fix an issue caused by the conversion of Path/PATH to string, it now uses a list as what nushell expects. This lead to repeating command not found issues.
  • Use -i in is-env-true in case the env name does not exist.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix (If there is a proper way let me know, I manually tested it)
  • added news fragment in docs/changelog folder (let me check other PRs to understand the expectations there)
  • updated/extended the documentation (same as previous)

melMass added 2 commits May 17, 2023 16:32
- Storing "Old" env variables is handled by overlays OOB
- Fix an issue caused by the conversion of Path/PATH to string,
  it now uses a list as what nushell expects. This lead to repeating
  command not found issues.
- Use `-i` in is-env-true in case the env name does not exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants