Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print command to print_prompt for nushell #2514

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

NotLebedev
Copy link
Contributor

@NotLebedev NotLebedev commented Mar 7, 2023

Change the way nushell test script prints prompt.
Nushell is about to make intermediate operations of scripts discard value instead of printing it nushell/nushell#8292. To address this issue an explicit print is added.
This change is compatible with current version of nushell, because print is an existing command.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@gaborbernat gaborbernat merged commit 0398e5b into pypa:main Mar 10, 2023
@NotLebedev NotLebedev deleted the nu-test-print-fix branch March 10, 2023 18:47
tarpas pushed a commit to tarpas/virtualenv that referenced this pull request Jun 8, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants