Try to fix Nushell install #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because pypa@e4a42c6 didn't seem to solve the issue, this is an alternative solution.
vfazio
reviewed
Nov 10, 2022
| @@ -45,8 +45,8 @@ jobs: | |||
| ${{ runner.os == 'Linux' && 'sudo apt-get install curl wget -y' || true }} && \ | |||
| ${{ runner.os == 'Linux' && 'nushell_url=$(curl -s https://api.github.com/repos/nushell/nushell/releases/latest | grep "browser_" | grep "x86_64" | grep "linux" | grep "gnu" | cut -d\" -f4 )' || true }} && \ | |||
| ${{ runner.os == 'Linux' && 'wget -O nushell.tar.gz $nushell_url' || true }} && \ | |||
| ${{ runner.os == 'Linux' && 'tar -zxf --strip-components=1 nushell.tar.gz' || true }} && \ | |||
There was a problem hiding this comment.
Seems easier to just make this
tar -zxf nushell.tar.gz --strip-components=1
instead of trying to glob the file path
There was a problem hiding this comment.
That was tried before but didn't work
There was a problem hiding this comment.
There's a very important order of arguments. GNU Tar requires a filename immediately after -f. Currently --strip-components=1 is being interpreted as a filename and is invalid. it needs to be placed after the filename or before the other arguments.
There was a problem hiding this comment.
The problem with pattern matching is that if the triplet changes, this will break again. using --strip-components obviates that.
just my $.02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because e4a42c6 didn't seem to solve the issue, this is an alternative solution.
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!
tox -e fix_lint)docs/changelogfolder