When setting prefixes to empty strings, check the key names in addition to value #2401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Fedora, we are currently trying to come up with a safe approach that
will make
sudo pip
and similar install to /usr/local rather than /usr.After years of only patching distutils for this,
we need to adapt our change to use sysconfig.
In the past, we've tried to use a custom installation scheme,
but that has yielded many unexpected side effects for our users.
Now we try to set the defaults of {base} and {platbase} to /usr/local instead.
However, such value is not in the prefixes listed in this check in virtualenv.
Here, I adapted the code to be more robust for such changes:
Let me know if this is acceptable to virtualenv. An alternative would be something like:
Or:
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!
tox -e fix_lint
)docs/changelog
folderI plan to work on tests and docs after we agree on the best approach to fix this.