Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies and build tools #2394

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

gaborbernat
Copy link
Contributor

Signed-off-by: Bernát Gábor [email protected]

distlib>=0.3.5,<1
filelock>=3.4.1,<4
platformdirs>=2.4,<3
importlib-metadata>=4.8.3;python_version < "3.8"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had issues when requiring tox and flake8 because of this pin.
Shortened error from pip-compile-multi:

Could not find a version that matches importlib-metadata<4.3,>=0.12,>=0.22,>=1.1.0,>=4.8.3 (from tox==3.25.1->-r requirements/local.in (line 3))
Tried: ............
There are incompatible versions in the resolved dependencies:
  .......
  importlib-metadata<4.3,>=1.1.0 (from flake8==5.0.4->-r requirements/test.in (line 6))
  importlib-metadata>=4.8.3 (from virtualenv==20.16.3->tox==3.25.1->-r requirements/local.in (line 3))

In my case, pinning virtualenv==20.16.2 ; python_version < '3.7' avoids the problem, but my project will be locked on virtualenv version 20.16.2 until this can be resolved.

Is there a reason for importlib-metadata to be pinned as >=4.8.3? I'm not super familiar with the library, and the problems around it, but unfortunately looks this isn't the only issue out there when projects pin it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for importlib-metadata to be pinned as >=4.8.3?

That's the only version we actually test with in our CI and is the only version I'm comfortable saying it's supported. I recommend reaching out to other projects that upper pin to remove.

@gaborbernat gaborbernat deleted the bump-tools branch August 9, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants