Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?? prompt should be wrapped in paranthesis ?? #2224

Merged
merged 24 commits into from
Oct 31, 2021
Merged

?? prompt should be wrapped in paranthesis ?? #2224

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
32b62f2
Fix formatting of `--promt=.`
tusharsadhwani Oct 24, 2021
dff9db1
Fix test
tusharsadhwani Oct 24, 2021
82a00f7
Merge branch 'main' into prompt-formatting
tusharsadhwani Oct 28, 2021
4cee181
Revert old changes
tusharsadhwani Oct 28, 2021
b2a629f
Add parentheses to activation scripts
tusharsadhwani Oct 28, 2021
889732f
Add PS1 test
tusharsadhwani Oct 28, 2021
9825371
Fix fish test
tusharsadhwani Oct 30, 2021
8376963
Simplify fish command
tusharsadhwani Oct 30, 2021
54e4eff
Simplify fish even more
tusharsadhwani Oct 30, 2021
e69a744
Add powershell test
tusharsadhwani Oct 30, 2021
fd74ade
Adjust fish activation script
tusharsadhwani Oct 30, 2021
15dd59b
Fix csh
tusharsadhwani Oct 30, 2021
f907730
Fix csh
tusharsadhwani Oct 30, 2021
287563f
Add batch
tusharsadhwani Oct 30, 2021
f2d286a
Add nushell
tusharsadhwani Oct 30, 2021
d5d98b6
Add newline for nushell
tusharsadhwani Oct 30, 2021
c3c2a46
Fix nushell prompt
tusharsadhwani Oct 30, 2021
cf98a78
Improve prompt code a little bit
tusharsadhwani Oct 30, 2021
9c0523e
Try using white instead of normal
tusharsadhwani Oct 30, 2021
0b19fd5
Remove set_color
tusharsadhwani Oct 30, 2021
d54bfc9
windows messes up non ascii chars
tusharsadhwani Oct 30, 2021
d67fbaa
Fix comment
tusharsadhwani Oct 31, 2021
f2ec7b8
Add changelog entry
tusharsadhwani Oct 31, 2021
1d4aa3d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/virtualenv/activation/activator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def __init__(self, options):

:param options: the parsed options as defined within :meth:`add_parser_arguments`
"""
self.flag_prompt = os.path.basename(os.getcwd()) if options.prompt == "." else options.prompt
self.flag_prompt = "({}) ".format(os.path.basename(os.getcwd())) if options.prompt == "." else options.prompt
gaborbernat marked this conversation as resolved.
Show resolved Hide resolved

@classmethod
def supports(cls, interpreter):
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/activation/test_activator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ def generate(self, creator):
monkeypatch.chdir(cwd)

activator = FakeActivator(Namespace(prompt="."))
assert activator.flag_prompt == "magic"
assert activator.flag_prompt == "(magic) "