Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error instead of creating non-working env #2179

Closed
wants to merge 1 commit into from
Closed

Show an error instead of creating non-working env #2179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog/2179.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Show an error instead of creating non-working env for Python 2 on Apple Silicon (M1) Macs.
10 changes: 10 additions & 0 deletions src/virtualenv/create/via_global_ref/builtin/cpython/mac_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from six import add_metaclass

from virtualenv.create.via_global_ref.builtin.ref import ExePathRefToDest, PathRefToDest, RefMust
from virtualenv.info import IS_MAC_ARM64
from virtualenv.util.path import Path
from virtualenv.util.six import ensure_text

Expand Down Expand Up @@ -102,6 +103,15 @@ def reload_code(self):
)
return result

@classmethod
def can_create(cls, interpreter):
if IS_MAC_ARM64:
# https://github.com/pypa/virtualenv/issues/2024
logging.fatal("Creating virtualenv for Python 2 on Apple Silicon Macs is not supported as of now.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to remove this, as this would still print if someone adds support via a plugin

Copy link
Contributor Author

@gdubicki gdubicki Sep 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a review @gaborbernat !

Unfortunately I am not familiar with this project's structure yet. Can you recommend a better place to put this check then?

Alternatively we could change this to:

logging.warning("The built-in creator does not handle creating virtualenvs for Python 2 on Apple Silicon Macs as of now.")

- that should not be misleading for a person that adds their own plugin to support this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The location is good. There isn't a place to put the warning message though, so that needs to be removed just.

Copy link
Contributor Author

@gdubicki gdubicki Sep 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid that without this message this PR doesn't make sense as the whole point was to show a friendly error that explains what happened.

If I would get the generic "No virtualenv implementation" error then I would assume that something is wrong with my Python / virtualenv setup, not that it is actually a missing virtualenv feature. And I think that other users would do the same.

Maybe it would be easier for you to implement the missing plugin instead? I would love to do it myself but I just don't know enough about Mach-O hacking for it to make sense... I am willing to do all the testing you need and as it seems that we are in similar timezones (BST / CEST) we could sync easily.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to do it myself but I just don't know enough about Mach-O hacking to it to make sense

Me neither... And I don't have access to an Apple M1 machine to write an implementation for it or time to do that. So guess we wait until someone comes along who does.

return False
else:
return super(CPythonmacOsFramework, cls).can_create(interpreter)


class CPython3macOsFramework(CPythonmacOsFramework, CPython3, CPythonPosix):
@classmethod
Expand Down
1 change: 1 addition & 0 deletions src/virtualenv/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
PY3 = sys.version_info[0] == 3
PY2 = sys.version_info[0] == 2
IS_WIN = sys.platform == "win32"
IS_MAC_ARM64 = sys.platform == "darwin" and platform.machine() == "arm64"
ROOT = os.path.realpath(os.path.join(os.path.abspath(__file__), os.path.pardir, os.path.pardir))
IS_ZIPAPP = os.path.isfile(ROOT)
WIN_CPYTHON_2 = IS_CPYTHON and IS_WIN and PY2
Expand Down