Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py 3.13: Twine imports cgi that doesn't exist #1046

Closed
1 task done
arcivanov opened this issue Feb 9, 2024 · 1 comment · Fixed by #1047
Closed
1 task done

Py 3.13: Twine imports cgi that doesn't exist #1046

arcivanov opened this issue Feb 9, 2024 · 1 comment · Fixed by #1047
Labels
enhancement feature request

Comments

@arcivanov
Copy link

Is there an existing issue for this?

  • I have searched the existing issues (open and closed), and could not find an existing issue

What keywords did you use to search existing issues?

No response

Please describe why your using this option

  1. The template "Bug" is broken: https://github.com/pypa/twine/blob/main/.github/ISSUE_TEMPLATE/02_bug.yml

image

  1. Twine fails with Python 3.13 due to trying to import cgi
 	    error = cli.dispatch(sys.argv[1:])
	            ~~~~~~~~~~~~^^^^^^^^^^^^^^
	  File "/opt/hostedtoolcache/Python/3.13.0-alpha.3/x64/lib/python3.13/site-packages/twine/cli.py", line 121, in dispatch
	    main = registered_commands[args.command].load()
	           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
	  File "/opt/hostedtoolcache/Python/3.13.0-alpha.3/x64/lib/python3.13/site-packages/importlib_metadata/__init__.py", line 184, in load
	    module = import_module(match.group('module'))
	             ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
	  File "/opt/hostedtoolcache/Python/3.13.0-alpha.3/x64/lib/python3.13/importlib/__init__.py", line 88, in import_module
	    return _bootstrap._gcd_import(name[level:], package, level)
	           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
	  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
	  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
	  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
	  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
	  File "<frozen importlib._bootstrap_external>", line 1012, in exec_module
	  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
	  File "/opt/hostedtoolcache/Python/3.13.0-alpha.3/x64/lib/python3.13/site-packages/twine/commands/check.py", line 16, in <module>
	    import cgi

Anything else you'd like to mention?

No response
@sigmavirus24
Copy link
Member

See also #969

@sigmavirus24 sigmavirus24 mentioned this issue Feb 11, 2024
Merged
sreenithi added a commit to sreenithi/grpc that referenced this issue Sep 14, 2024
@sreenithi
updated twine version to solve pypa/twine#1046
b39d95f
@sreenithi sreenithi mentioned this issue Sep 16, 2024
Closed
copybara-service bot pushed a commit to grpc/grpc that referenced this issue Sep 26, 2024
@sreenithi @copybara-github
Add templating and support for Python 3.13 (#37643)
f2ffbb8 
This PR adds templating for Python versions and updates the maximum supported Python version to 3.13. The following major changes related to templating are added:
 - Minimum supported Python version and list of supported versions in `setup.py` are fetched using new template generated files called `python_version.py`
 - Dockerfiles for the different Python Linux builds are now template generated.
 - The "Supported Python Versions" section from READMEs of ancillary and main packages have been removed

Note: All the `python_version.py` files and Linux build `Dockerfiles` except `tools/dockerfile/grpc_artifact_python_linux_armv7/Dockerfile` in the PR are generated from the respective templates.

Further non-templated additions to add support for Python 3.13:
 - install scripts and artifacts for windows, macos and linux are added manually. Later, these can be templated as well.
 - updated cython bounds to 3.x
 - updated twine version to solve [cgi module import error](pypa/twine#1046)
 - the twine update introduces a dependency on cryptography>=2.0. But the cryptography package doesn't support 32-bit Linux images and hence `twine check` has been disabled for x86 manylinux and x86 musllinux artifacts.

Closes #37643

PiperOrigin-RevId: 678954495
sreenithi added a commit to sreenithi/grpc that referenced this issue Sep 26, 2024
@sreenithi
Add templating and support for Python 3.13 (grpc#37643)
076b042 
This PR adds templating for Python versions and updates the maximum supported Python version to 3.13. The following major changes related to templating are added:
 - Minimum supported Python version and list of supported versions in `setup.py` are fetched using new template generated files called `python_version.py`
 - Dockerfiles for the different Python Linux builds are now template generated.
 - The "Supported Python Versions" section from READMEs of ancillary and main packages have been removed

Note: All the `python_version.py` files and Linux build `Dockerfiles` except `tools/dockerfile/grpc_artifact_python_linux_armv7/Dockerfile` in the PR are generated from the respective templates.

Further non-templated additions to add support for Python 3.13:
 - install scripts and artifacts for windows, macos and linux are added manually. Later, these can be templated as well.
 - updated cython bounds to 3.x
 - updated twine version to solve [cgi module import error](pypa/twine#1046)
 - the twine update introduces a dependency on cryptography>=2.0. But the cryptography package doesn't support 32-bit Linux images and hence `twine check` has been disabled for x86 manylinux and x86 musllinux artifacts.

Closes grpc#37643

PiperOrigin-RevId: 678954495
@sreenithi sreenithi mentioned this issue Sep 26, 2024
Merged
sreenithi added a commit to sreenithi/grpc that referenced this issue Sep 26, 2024
@sreenithi
Add templating and support for Python 3.13 (grpc#37643)
a4fd219 
This PR adds templating for Python versions and updates the maximum supported Python version to 3.13. The following major changes related to templating are added:
 - Minimum supported Python version and list of supported versions in `setup.py` are fetched using new template generated files called `python_version.py`
 - Dockerfiles for the different Python Linux builds are now template generated.
 - The "Supported Python Versions" section from READMEs of ancillary and main packages have been removed

Note: All the `python_version.py` files and Linux build `Dockerfiles` except `tools/dockerfile/grpc_artifact_python_linux_armv7/Dockerfile` in the PR are generated from the respective templates.

Further non-templated additions to add support for Python 3.13:
 - install scripts and artifacts for windows, macos and linux are added manually. Later, these can be templated as well.
 - updated cython bounds to 3.x
 - updated twine version to solve [cgi module import error](pypa/twine#1046)
 - the twine update introduces a dependency on cryptography>=2.0. But the cryptography package doesn't support 32-bit Linux images and hence `twine check` has been disabled for x86 manylinux and x86 musllinux artifacts.

Closes grpc#37643

PiperOrigin-RevId: 678954495
@sreenithi sreenithi mentioned this issue Sep 26, 2024
Merged
sourabhsinghs pushed a commit to sourabhsinghs/grpc that referenced this issue Sep 26, 2024
@sreenithi @sourabhsinghs
Add templating and support for Python 3.13 (grpc#37643)
9a80064 
This PR adds templating for Python versions and updates the maximum supported Python version to 3.13. The following major changes related to templating are added:
 - Minimum supported Python version and list of supported versions in `setup.py` are fetched using new template generated files called `python_version.py`
 - Dockerfiles for the different Python Linux builds are now template generated.
 - The "Supported Python Versions" section from READMEs of ancillary and main packages have been removed

Note: All the `python_version.py` files and Linux build `Dockerfiles` except `tools/dockerfile/grpc_artifact_python_linux_armv7/Dockerfile` in the PR are generated from the respective templates.

Further non-templated additions to add support for Python 3.13:
 - install scripts and artifacts for windows, macos and linux are added manually. Later, these can be templated as well.
 - updated cython bounds to 3.x
 - updated twine version to solve [cgi module import error](pypa/twine#1046)
 - the twine update introduces a dependency on cryptography>=2.0. But the cryptography package doesn't support 32-bit Linux images and hence `twine check` has been disabled for x86 manylinux and x86 musllinux artifacts.

Closes grpc#37643

PiperOrigin-RevId: 678954495
gnossen pushed a commit to grpc/grpc that referenced this issue Sep 26, 2024
@sreenithi
[Backport to v1.66.x] Add templating and support for Python 3.13 (#37643
4ca1787 
) (#37802)

This PR adds templating for Python versions and updates the maximum
supported Python version to 3.13. The following major changes related to
templating are added:
- Minimum supported Python version and list of supported versions in
`setup.py` are fetched using new template generated files called
`python_version.py`
- Dockerfiles for the different Python Linux builds are now template
generated.
- The "Supported Python Versions" section from READMEs of ancillary and
main packages have been removed

Note: All the `python_version.py` files and Linux build `Dockerfiles`
except `tools/dockerfile/grpc_artifact_python_linux_armv7/Dockerfile` in
the PR are generated from the respective templates.

Further non-templated additions to add support for Python 3.13:
- install scripts and artifacts for windows, macos and linux are added
manually. Later, these can be templated as well.
 - updated cython bounds to 3.x
- updated twine version to solve [cgi module import
error](pypa/twine#1046)
- the twine update introduces a dependency on cryptography>=2.0. But the
cryptography package doesn't support 32-bit Linux images and hence
`twine check` has been disabled for x86 manylinux and x86 musllinux
artifacts.

Closes #37643

PiperOrigin-RevId: 678954495




<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
gnossen pushed a commit to grpc/grpc that referenced this issue Sep 26, 2024
@sreenithi
[Backport to 1.67.x] Add templating and support for Python 3.13 (#37643…
bcfee53 
…) (#37803)

This PR adds templating for Python versions and updates the maximum
supported Python version to 3.13. The following major changes related to
templating are added:
- Minimum supported Python version and list of supported versions in
`setup.py` are fetched using new template generated files called
`python_version.py`
- Dockerfiles for the different Python Linux builds are now template
generated.
- The "Supported Python Versions" section from READMEs of ancillary and
main packages have been removed

Note: All the `python_version.py` files and Linux build `Dockerfiles`
except `tools/dockerfile/grpc_artifact_python_linux_armv7/Dockerfile` in
the PR are generated from the respective templates.

Further non-templated additions to add support for Python 3.13:
- install scripts and artifacts for windows, macos and linux are added
manually. Later, these can be templated as well.
 - updated cython bounds to 3.x
- updated twine version to solve [cgi module import
error](pypa/twine#1046)
- the twine update introduces a dependency on cryptography>=2.0. But the
cryptography package doesn't support 32-bit Linux images and hence
`twine check` has been disabled for x86 manylinux and x86 musllinux
artifacts.

Closes #37643

PiperOrigin-RevId: 678954495




<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
paulosjca pushed a commit to paulosjca/grpc that referenced this issue Nov 25, 2024
@sreenithi @paulosjca
Add templating and support for Python 3.13 (grpc#37643)
b3ad5d1 
This PR adds templating for Python versions and updates the maximum supported Python version to 3.13. The following major changes related to templating are added:
 - Minimum supported Python version and list of supported versions in `setup.py` are fetched using new template generated files called `python_version.py`
 - Dockerfiles for the different Python Linux builds are now template generated.
 - The "Supported Python Versions" section from READMEs of ancillary and main packages have been removed

Note: All the `python_version.py` files and Linux build `Dockerfiles` except `tools/dockerfile/grpc_artifact_python_linux_armv7/Dockerfile` in the PR are generated from the respective templates.

Further non-templated additions to add support for Python 3.13:
 - install scripts and artifacts for windows, macos and linux are added manually. Later, these can be templated as well.
 - updated cython bounds to 3.x
 - updated twine version to solve [cgi module import error](pypa/twine#1046)
 - the twine update introduces a dependency on cryptography>=2.0. But the cryptography package doesn't support 32-bit Linux images and hence `twine check` has been disabled for x86 manylinux and x86 musllinux artifacts.

Closes grpc#37643

PiperOrigin-RevId: 678954495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New release pypa/twine
2 participants
@sigmavirus24 @arcivanov