Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make pre-commit faster #198

Merged
merged 1 commit into from
May 1, 2024
Merged

chore: make pre-commit faster #198

merged 1 commit into from
May 1, 2024

Conversation

henryiii
Copy link
Contributor

This is recommended as it gives the compiled wheel of black instead of building from source and skipping the mypyc optimizations.

There's also ruff-format, which is already available in the ruff pre-commit hook and could be swapped out if you want.

@takluyver takluyver added this to the 1.2 milestone May 1, 2024
@takluyver
Copy link
Member

Thanks, I'm happy with this. 👍

Do you have opinions on https://pre-commit.ci/ ? It claims to run these checks much faster than doing them as part of normal CI.

@takluyver takluyver merged commit 5f18842 into pypa:main May 1, 2024
20 checks passed
@henryiii
Copy link
Contributor Author

henryiii commented May 1, 2024

I’m a fan, and use it in most repos. It’s fast (though GHA is fast). It’s really nice for the autofix and auto update features (can be opted out).

You need someone with access to all pypa repos to enable it, I think. Unless GitHub fixed the “feature” that disabled all repos that a user didn’t have access to when you modify access. That happened to me about a year ago. 😳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants