Set up trusted publishing for making releases to PyPI #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Nov 21, 2024
| FLIT_PASSWORD: ${{ secrets.PYPI_TOKEN }} | ||
| - run: | | ||
| pip install build | ||
| python -m build |
There was a problem hiding this comment.
@takluyver this bit is problematic — it's discouraged to build in the same job that has elevated privileges and is able to access OIDC.
I recommend splitting it out due to security concerns: https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
webknjaz
reviewed
Nov 21, 2024
| @@ -46,16 +46,21 @@ jobs: | |||
| name: Publish release | |||
| runs-on: ubuntu-latest | |||
| needs: tests | |||
| environment: release | |||
There was a problem hiding this comment.
I recommend using pypi since it's a name of the deployment target. I also fixed the suggested name in Warehouse to match this recommendation a few weeks ago. Plus the PyPUG and GH docs use this too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pradyunsg does this look OK? I've reconfigured PyPI to allow publishing from
ci.yml, because I like the publish job to run only after the tests have passed, and that's easier if they're in the same file.Closes #186.