Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate setup.py install fallback when bdist_wheel fails #8369

Merged
merged 3 commits into from
Jul 18, 2020
Merged

Deprecate setup.py install fallback when bdist_wheel fails #8369

merged 3 commits into from
Jul 18, 2020

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented May 31, 2020

Towards #8368

@sbidoul sbidoul force-pushed the deprecate-pip-install-on-bdist_wheel-failure branch from c2e41e7 to d10c69f Compare May 31, 2020 12:04
@sbidoul sbidoul added C: build logic Stuff related to metadata generation / wheel generation type: deprecation Related to deprecation / removal. labels May 31, 2020
@sbidoul sbidoul mentioned this pull request May 31, 2020
Closed
xavfernandez
xavfernandez approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that 20.3 might be too soon but I might be wrong and we can always postpone it to 21.x if needed :)

@sbidoul sbidoul mentioned this pull request Jul 17, 2020
Closed
pradyunsg
pradyunsg reviewed Jul 17, 2020
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the 20.3 to 21.0 (given our current deprecation policy) and this is good to go. :)

@pradyunsg pradyunsg added this to the 20.2 milestone Jul 17, 2020
sbidoul added 3 commits July 18, 2020 13:46
@sbidoul
Deprecate install fallback when bdist_wheel fails
462d6ca
@sbidoul
Quote 'setup.py install' when calling it legacy
fe56826 
We want to make it clear that it is the setup.py install command we consider
legacy, not setup.py itself.
@sbidoul
Give mypy some love after rebase
d924b16
@sbidoul sbidoul force-pushed the deprecate-pip-install-on-bdist_wheel-failure branch from 1617f59 to d924b16 Compare July 18, 2020 11:46
@sbidoul
Copy link
Member Author

sbidoul commented Jul 18, 2020

@pradyunsg done. After rebase I had to add a commit to please mypy, python 2 while accomodating a black code style at the same time. 😓

@pradyunsg
Copy link
Member

mypy, python 2 while accomodating a black code style

Well, you're trying to make too many tools happy. It's obviously gonna be difficult. :P

@pradyunsg pradyunsg merged commit d01aeaa into pypa:master Jul 18, 2020
@sbidoul sbidoul deleted the deprecate-pip-install-on-bdist_wheel-failure branch July 18, 2020 19:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees
No one assigned
Labels
C: build logic Stuff related to metadata generation / wheel generation type: deprecation Related to deprecation / removal.
Projects
None yet
Milestone
20.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sbidoul @pradyunsg @xavfernandez