Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --proxy Option To Build Environment #13075

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

martinezlc99
Copy link

@martinezlc99 martinezlc99 commented Nov 10, 2024

Fixes #6018

I have ran into this issue a few times when my corporate proxy was not set in my shell. As mentioned in #6018 (comment), I can reliably replicate this issue in my corporate environment, although I do not make use of any pip environmental variables.

My environment makes use of a private PyPI server and associated extra index URL(s) and trusted host(s). Note in my case, it was only the --proxy option that was missing. I mention this since I cannot say for sure if this will solve all issues, although it seems environmental variables are available in the build environment - hence the workaround mentioned in #6018 (comment).

I did not add any tests as I was not sure how to test the use of a proxy in the build environment. The existing tests for the --proxy option seemed adequate. Glad to add a test for a specific scenario if anyone has any ideas.

@notatallshaw
Copy link
Member

I'm going to add this to the 25.0 milestone so it's not forgotten, but someone will still need to volunteer to review and/or accept.

@notatallshaw notatallshaw added this to the 25.0 milestone Dec 3, 2024
@ichard26 ichard26 self-requested a review December 11, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyproject.toml-based builds lose proxy config for build-dependency installation
2 participants