-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support per-requirement --config-settings for editables #12494
Merged
sbidoul
merged 2 commits into
pypa:main
from
sbidoul:pass-config-settings-to-editable-in-req-file-sbi
Jan 31, 2024
Merged
Support per-requirement --config-settings for editables #12494
sbidoul
merged 2 commits into
pypa:main
from
sbidoul:pass-config-settings-to-editable-in-req-file-sbi
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sbidoul
force-pushed
the
pass-config-settings-to-editable-in-req-file-sbi
branch
from
January 27, 2024 18:09
5b4bd40
to
24449a2
Compare
sbidoul
changed the title
Per-requirement --config-settings not working for editable_mode
Support per-requirement --config-settings for editables
Jan 27, 2024
sbidoul
force-pushed
the
pass-config-settings-to-editable-in-req-file-sbi
branch
2 times, most recently
from
January 28, 2024 12:15
903d7c3
to
4296e5a
Compare
If anyone is available to do a quick review here, I can include it in 24.0 too. |
chrysle
reviewed
Jan 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! Minor comments, feel free to discard.
chrysle
reviewed
Jan 28, 2024
sbidoul
force-pushed
the
pass-config-settings-to-editable-in-req-file-sbi
branch
from
January 28, 2024 14:18
1bf6fe4
to
7f800a2
Compare
1 task
sbidoul
force-pushed
the
pass-config-settings-to-editable-in-req-file-sbi
branch
from
January 29, 2024 21:28
7f800a2
to
1f48ca3
Compare
@pypa/pip-committers no objections with landing this in 24.0? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12480