Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let --config-settings imply PEP 517 #11917

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Let --config-settings imply PEP 517 #11917

merged 4 commits into from
Jan 30, 2024

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Apr 2, 2023

closes #11915

@sbidoul sbidoul added the C: build logic Stuff related to metadata generation / wheel generation label Apr 2, 2023
@sbidoul sbidoul added this to the 23.1 milestone Apr 2, 2023
@sbidoul sbidoul mentioned this pull request Apr 2, 2023
Closed
@sbidoul sbidoul modified the milestones: 23.1, 23.3 Apr 2, 2023
@sbidoul sbidoul modified the milestones: 23.3, 24.0 Oct 1, 2023
@sbidoul sbidoul added the type: deprecation Related to deprecation / removal. label Oct 8, 2023
@sbidoul sbidoul force-pushed the config-settings-implies-pep517-sbi branch from afd7594 to c95d8b2 Compare January 27, 2024 13:09
@sbidoul sbidoul marked this pull request as ready for review January 27, 2024 13:10
@sbidoul sbidoul force-pushed the config-settings-implies-pep517-sbi branch from c95d8b2 to 58bca46 Compare January 27, 2024 17:22
@sbidoul sbidoul force-pushed the config-settings-implies-pep517-sbi branch from a152d3c to 0d20112 Compare January 28, 2024 12:10
@sbidoul
Copy link
Member Author

sbidoul commented Jan 28, 2024 •
edited
Loading

Thanks for the review @pradyunsg.

Note I tweaked this a little bit after your review to

  • warn instead of fail when --no-use-pep517 is used at the same time as --config-setting (this is safer)
  • warn when --config-setting are used for editable installs with a setuptools version that does not support PEP 660

@sbidoul sbidoul force-pushed the config-settings-implies-pep517-sbi branch from aebf7ca to 3209e69 Compare January 30, 2024 19:50
@sbidoul sbidoul force-pushed the config-settings-implies-pep517-sbi branch from 3209e69 to cfab072 Compare January 30, 2024 19:50
@sbidoul sbidoul merged commit cfe5f9a into pypa:main Jan 30, 2024
26 checks passed
@sbidoul sbidoul deleted the config-settings-implies-pep517-sbi branch January 30, 2024 21:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrysle chrysle chrysle left review comments

@uranusjr uranusjr uranusjr left review comments

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided C: build logic Stuff related to metadata generation / wheel generation type: deprecation Related to deprecation / removal.
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.

Automatically enable PEP 517 when --config-settings are used for legacy projects
4 participants
@sbidoul @uranusjr @pradyunsg @chrysle