Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the way to decide if keyring is available #11774

Merged
merged 3 commits into from
Feb 3, 2023
Merged

fix: correct the way to decide if keyring is available #11774

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9058b90
fix: correct the way to decide if keyring is available
frostming Feb 3, 2023
706456c
add news
frostming Feb 3, 2023
2d0a5c9
use a attribute to tell if the provider is null
frostming Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/11774.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Correct the way to decide if keyring is available.
2 changes: 1 addition & 1 deletion src/pip/_internal/network/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def _prompt_for_password(

# Factored out to allow for easy patching in tests
def _should_save_password_to_keyring(self) -> bool:
if get_keyring_provider() is None:
if isinstance(get_keyring_provider(), KeyRingNullProvider):
return False
return ask("Save credentials to keyring [y/N]: ", ["y", "n"]) == "y"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should refactor this whole thing into the provider classes. Checking isinstance here feels like an anti-pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, but may need to suggest a better name


Expand Down